Made functions public #49
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure why you would want to manually call these functions. Could you perhaps explain your use-case? |
|
I'm not sure why you would want to manually call these functions. Could you perhaps explain your use-case?
In Decode.swift you have the following definition:
/// Decode a JWT
public func decode(_ jwt:String, algorithms:[Algorithm], verify:Bool = true, audience:String? = nil, issuer:String? = nil) throws -> Payload {
verify defaults to true but could be false, so you can decode a token without verifying it. If you do this I think you should have the option to manually call the verify functions at a later stage.
Danny
|
|
Alright, I've made these public in e36d4f0. I wanted to expose these in a different way (on the new let claims = try JWT.decode("eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.e30.2_8pWJfyPup0YwOXK7g9Dn0cF1E3pdn299t4hSeJy5w", algorithm: .hs256("secret".data(using: .utf8)!), verify: false)
try claims.validateAudience("example.com")
try claims.validateIssuer("fuller.li")
try claims.validateExpiary()
try claims.validateNotBefore()
try claims.validateIssuedAt() |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So they can be used in other modules